mentionutil: Add a mentions extractor #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgallice
requested review from
GaelLnz and
DarkMiMolle
and removed request for
a team
xgoffin
approved these changes
Sep 10, 2024
tgallice
force-pushed
the
thomasgallice/lib-64-update-amplification-process-by-using-mentions
branch
from
6d7e0a2 to
b935b98
Compare
tgallice
force-pushed
the
thomasgallice/lib-64-update-amplification-process-by-using-mentions
branch
from
b935b98 to
022c5c6
Compare
tgallice
commented
Sep 10, 2024
| }, | ||
| { | ||
| name: "youtube url", | ||
| input: "foo bar @buz. https://www.youtube.com/@SalonViking test", |
There was a problem hiding this comment.
The bad thing of this it's this catch also handle from tiktok or instagram urls but we didn't know at the end at which social media it's linked. This could lead to some confusion. Maybe must be more restrictive ?
tgallice
deleted the
thomasgallice/lib-64-update-amplification-process-by-using-mentions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a mentions extractor method.
Not sure of the pertinence to put this here but voila.
What are the observable changes?
Good PR checklist
Additional Notes